targets/wasm_exec: add runtime.getRandomData to gojs imports#5363
Open
pedramktb wants to merge 1 commit intotinygo-org:devfrom
Open
targets/wasm_exec: add runtime.getRandomData to gojs imports#5363pedramktb wants to merge 1 commit intotinygo-org:devfrom
pedramktb wants to merge 1 commit intotinygo-org:devfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Updates TinyGo’s wasm_exec.js import object to include runtime.getRandomData, matching the upstream Go wasm_exec.js behavior, to prevent instantiation failures with newer TinyGo-generated WASM modules.
Changes:
- Add a
gojsimport implementation forruntime.getRandomDatathat fills a WASM memory slice viacrypto.getRandomValues.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
pedramktb
force-pushed
the
fix/wasm-exec-getRandomData
branch
from
df45c80 to
4c851a3
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+297
to
+304
| // func getRandomData(r []byte) | ||
| "runtime.getRandomData": (slice_ptr, slice_len, slice_cap) => { | ||
| const buf = loadSlice(slice_ptr, slice_len, slice_cap); | ||
| // crypto.getRandomValues has a 65536-byte limit per call | ||
| for (let offset = 0; offset < buf.length; offset += 65536) { | ||
| crypto.getRandomValues(buf.subarray(offset, Math.min(offset + 65536, buf.length))); | ||
| } | ||
| }, |
pedramktb
force-pushed
the
fix/wasm-exec-getRandomData
branch
from
4c851a3 to
0be4a9a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TinyGo v0.37.0 updated the net submodule (tinygo-org/net) which introduced
a call to runtime.getRandomData in the compiled wasm binary. Without a
corresponding JS implementation in the gojs import object, instantiating
the module throws:
LinkError: WebAssembly.Instance(): Import # 17 "gojs" "runtime.getRandomData":
function import requires a callable
The addition is already present at the official go runtime package: https://github.com/golang/go/blob/master/lib/wasm/wasm_exec.js#L306-L309.
Fixes #5357