consider GOROOT/api as fallback to determine Go version #956
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a development branch of Go (see #435), the file
$GOROOT/VERSIONdoesn't exist, andsrc/runtime/internal/sys/zversion.gocontains a version string like the following:Instead of the expected format:
Thus
tinygowill fail to run without any existing means of determining version, for example:This change will look at the content of directory
$GOROOT/apito find the semantically greatest version only if the above two checks first fail, and the value ofconst TheVersionbegins with"devel"Note that this still won't allow current master branch to run, which will produce a version
go1.14, resulting in:$ tinygo flash -target pyportal . error: requires go version 1.11, 1.12, or 1.13, got go1.14But this is a separate unrelated issue (#901 I believe).