TINY-11177: Vastly improve remote testing#145
Merged
Conversation
spocke
approved these changes
Aug 16, 2024
Member
spocke
left a comment
spocke
left a comment
There was a problem hiding this comment.
How does this affect junit reporting would the in flight requests make them in random order or would things be skipped.
Member
Author
|
I posted in slack that this destroys JUnit reporting. Ideas for how to fix: |
TheSpyder
force-pushed
the
feature/TINY-11177
branch
from
4feac22 to
e80663d
Compare
ltrouton
reviewed
Sep 17, 2024
…it for the report AJAX requests to complete before moving on to the next test.
…it would be misleading if they were treated as passing.
…th test reports and offsets.
…ts. Manual mode works, auto still needs some work.
…to the end of the test run are now waited for correctly.
…ce for every result
…an empty rejected promise
…emoving it is a pain. Use es2019 instead.
…ote driver once every 4 minutes
…stopOnFailure in auto mode.
…p with identification (and already found a bug in tinymce)
…sily identify them
… elements it added
6 tasks
ltrouton
approved these changes
Jan 23, 2025
Contributor
ltrouton
left a comment
ltrouton
left a comment
There was a problem hiding this comment.
Not an expert on bedrock so don't know everything I am looking at but this looks like it will be a big improvement 👍
4 tasks
spocke
approved these changes
Jan 24, 2025
Member
spocke
left a comment
spocke
left a comment
There was a problem hiding this comment.
Looks good, lots of nice improvements beyond the perf things. 👍
Member
Author
|
Resolved all except one which I'll deal with on Monday and then release this 👍 |
…export I'll never know
…o simplify the code that calls it. Removed unnecessary export declarations, which means we no longer need a safety-net `checkSiblings` call in `runSuites` which will by definition never pass the root test suite condition.
Member
Author
|
I'm glad to finally finish this one |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Ticket: TINY-11177
Description of Changes:
/startbefore eachitblock, and then again to/resultsafter eachitblock. It would wait for these requests to finish before continuing./startis now sent at startup only./resultsis now only sent for failure and skip, or every 30 seconds if tests are passing happily.Promise.all()at the very end to wait for them.bedrockCLI console HUD depended on receiving these status updates, so I had to adjust it to account for the missing reports.favicon.icorequest which probably also slowed things down.keep-aliveheader is now set, instead of using the default 5 seconds which was causing occasional502 Bad Gatewayerrors.Pre-checks:
Tests have been added (if applicable)Before merging: