TINY-13550: Fix bedrock-auto error when using rspack bundler #160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shanmen-tiny
requested review from
ArvinJ-H,
TheSpyder,
kimwoodfield and
tiny-ben-tran
ltrouton
approved these changes
Dec 19, 2025
Co-authored-by: ltrouton <46954949+ltrouton@users.noreply.github.com>
shanmen-tiny
force-pushed
the
feature/TINY-13550
branch
from
797bc83 to
34478f1
Compare
jscasca
approved these changes
Dec 19, 2025
TheSpyder
reviewed
Dec 19, 2025
|
|
||
| export const compile = (bundler: 'webpack' | 'rspack', tsConfigFile: string, scratchDir: string, basedir: string, exitOnCompileError: boolean, files: string[], coverage: string[], polyfills: string[]): Compiler => { | ||
| const getCompileFunc = () => { | ||
| export const compile = (args: { bundler: Types.Bundler; tsConfigFile: string; scratchDir: string; basedir: string; exitOnCompileError: boolean; files: string[]; coverage: string[]; polyfills: string[]; |
Member
There was a problem hiding this comment.
There are ways to test development bedrock builds with real development processes, remind me next year and I'd be happy to discuss 👍
It would be nice to catch these things before we publish a release.
TheSpyder
approved these changes
Dec 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Ticket: TINY-13550
Description of Changes:
Pre-checks:
Before merging: