Skip to content

DOC-3250: HTML comments were not tracked correctly. #3813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kemister85 merged 2 commits into from
Aug 12, 2025
Merged

DOC-3250: HTML comments were not tracked correctly. #3813

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d88545
DOC-3250: HTML comments were not tracked correctly.
kemister85 Aug 7, 2025
d5406f3
Apply suggestions from code review
kemister85 Aug 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Empty file added modules/ROOT/examples/live-demos/button-css-override/index.html
View file
Open in desktop
Empty file.
Empty file added modules/ROOT/examples/live-demos/button-css-override/index.js
View file
Open in desktop
Empty file.
4 changes: 3 additions & 1 deletion modules/ROOT/pages/8.0.2-release-notes.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,9 @@ The {productname} {release-version} release includes an accompanying release of
==== HTML comments were not tracked correctly.
// TINY-12544

//CCFR here.
Previously, pagebreak separators defined as HTML comments (e.g., `+<!-- pagebreak -->+`) were not detected by the suggested edit system. This meant that insertions or deletions of these separators were not displayed as edits, making it difficult for reviewers to identify structural changes.

{productname} {release-version} now tracks pagebreak elements defined via HTML comments. When editors insert or delete `+<!-- pagebreak -->+` markers, these changes appear in the Review Edits view, ensuring reviewers have full visibility of all document structure modifications.

==== Elements with no visible height were not displaying in the Review Edits view.
// TINY-12257
Expand Down
Empty file added modules/ROOT/partials/configuration/button_css_override.adoc
View file
Open in desktop
Empty file.