Skip to content

DOC-2711: Documentation Enhancements for bundling-icons, and creating-an-icon-pack.#3870

Merged
kemister85 merged 6 commits intotinymce/8from
hotfix/8/DOC-2711
Sep 29, 2025
Merged

DOC-2711: Documentation Enhancements for bundling-icons, and creating-an-icon-pack.#3870
kemister85 merged 6 commits intotinymce/8from
hotfix/8/DOC-2711

Conversation

@kemister85
Copy link
Contributor

@kemister85 kemister85 commented Sep 26, 2025 •
edited
Loading

Ticket: DOC-2711
Supporting: DOC-2887 as changes impact this file also.

Site: creating and icon pack
Site: bundling icons

Changes:

  • Documentation improvements to existing outdated bundling-icon and creating an icon pack guides.
  • add new demo showcasing example of using default icons vs using custom icons with editor fallback for all other icons not being overridden.
  • TBA

Pre-checks:

  • Branch prefixed with feature/<version>/, hotfix/<version>/, staging/<version>/, or release/<version>/.

Review:

  • Documentation Team Lead has reviewed

kemister85
kemister85 commented Sep 26, 2025
View reviewed changes
@kemister85 kemister85 requested review from a team, TheSpyder, ltrouton, shanmen-tiny and tiny-ben-tran and removed request for a team September 28, 2025 22:56
@kemister85 kemister85 marked this pull request as ready for review September 28, 2025 22:56
kemister85
kemister85 commented Sep 28, 2025
View reviewed changes
ShiridiGandham
ShiridiGandham approved these changes Sep 29, 2025
View reviewed changes
Copy link
Contributor

@ShiridiGandham ShiridiGandham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kemister85 kemister85 merged commit d5ba942 into tinymce/8 Sep 29, 2025
5 checks passed
@kemister85 kemister85 deleted the hotfix/8/DOC-2711 branch September 29, 2025 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ArvinJ-H ArvinJ-H ArvinJ-H approved these changes

@ShiridiGandham ShiridiGandham ShiridiGandham approved these changes

@TheSpyder TheSpyder Awaiting requested review from TheSpyder TheSpyder was automatically assigned from tinymce/editor-platform-team

@ltrouton ltrouton Awaiting requested review from ltrouton ltrouton was automatically assigned from tinymce/editor-platform-team

@tiny-ben-tran tiny-ben-tran Awaiting requested review from tiny-ben-tran tiny-ben-tran was automatically assigned from tinymce/editor-platform-team

@shanmen-tiny shanmen-tiny Awaiting requested review from shanmen-tiny shanmen-tiny was automatically assigned from tinymce/editor-platform-team

@abhinavgandham abhinavgandham Awaiting requested review from abhinavgandham

@soritaheng soritaheng Awaiting requested review from soritaheng soritaheng is a code owner

@EkimChau EkimChau Awaiting requested review from EkimChau EkimChau is a code owner automatically assigned from tinymce/documentation-team

@tiny-james tiny-james Awaiting requested review from tiny-james tiny-james is a code owner automatically assigned from tinymce/documentation-team

@MitchC1999 MitchC1999 Awaiting requested review from MitchC1999 MitchC1999 is a code owner automatically assigned from tinymce/documentation-team

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kemister85 @ArvinJ-H @ShiridiGandham