Skip to content

INT-3226: Fix onEditorChanged called three times after calling insertContent on a selection #581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 22, 2025
Merged

INT-3226: Fix onEditorChanged called three times after calling insertContent on a selection #581

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a5a4a3f
INT-3226: Fix onEditorChange called three times after inserting conte…
hamza0867 Mar 12, 2025
1b5fa57
INT-3226: Add changelog entry
hamza0867 Mar 12, 2025
d77285b
INT-3226: Fix lint issue
hamza0867 Mar 12, 2025
b4007a3
INT-3226: fix as per review
hamza0867 Mar 18, 2025
06567e7
INT-3226: Fix test case
hamza0867 Mar 18, 2025
61241fa
INT-3226: Remove console log
hamza0867 Mar 18, 2025
63140fd
Update CHANGELOG.md
hamza0867 Mar 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/ts/components/Editor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { getTinymce } from '../TinyMCE';
import { configHandlers, isBeforeInputEventAvailable, isFunction, isInDoc, isTextareaOrInput, mergePlugins, setMode, uuid } from '../Utils';
import { EditorPropTypes, IEditorPropTypes } from './EditorPropTypes';

const changeEvents = 'change input compositionend setcontent CommentChange';
const changeEvents = 'change keyup compositionend setcontent CommentChange';

type OmitStringIndexSignature<T> = { [K in keyof T as string extends K ? never : K]: T[K] };

Expand Down