Blockstack server-side validation #20
Merged
+63
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10.
What This Does
Actually validates the information the user sends us about their Blockstack account by decoding their auth token, and looking up the data on Blockstack's Atlas node. This is still somewhat trusted since we're using their node, but I think the risks are pretty low on this one.
In order to decode a ES256K json web token, I had to use the version of the package that's currently in a pull request. Once that's merged and updated, we can use a pypi version.
Steps to Test
Auth with blockstack and confirm it works! Hard to test the negative use case (Someone spoofing a login) without editing the code, but you can give that a shot too.