Connect to default database to find all databases#211
Open
codemonium wants to merge 1 commit intotiredofit:mainfrom
Open
Connect to default database to find all databases#211codemonium wants to merge 1 commit intotiredofit:mainfrom
codemonium wants to merge 1 commit intotiredofit:mainfrom
Conversation
The psql call for finding all databases (which happens when DB_NAME is
ALL or SPLIT_DB is FALSE) fails if DB_USER is not an existing database.
This change stops using DB_USER for the -d option.
If you run psql without specifying -d/--dbname, it uses "postgres" by
default, going so far as to raise an error if it is missing:
/ # psql -U postgres
psql: error: FATAL: database "postgres" does not exist
I think it makes sense to use the same assumption for the psql call
mentioned above.
Contributor
Author
|
@tiredofit is there anything else I need to do to get this merged? |
Owner
|
Hi @codemonium - My apologies on the silence. I haven't had much time to look into much things for db-backup lately as I wanted to rewrite the tool. That release is imminent and I am now reviewing the PRs. This sounds similar to our DB_AUTH command which allows you to select an Authentication database first. Can you check to see if #262 solves this as well? There has been a PR that matches some of the work done for MongoDB moved over to PSQL recently that enables this function.. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
psqlcall for finding all databases (which happens whenDB_NAMEisALLorSPLIT_DBisFALSE) fails ifDB_USERis not an existing database. This change stops usingDB_USERfor the-doption.If you run
psqlwithout specifying-d/--dbname, it usespostgresby default, going so far as to raise an error if it is missing:I think it makes sense to use the same assumption for the
psqlcall mentioned above.For users who don't have the default
postgresdatabase in their cluster, we could add a new configuration optionDB_SOMETHING_OR_OTHERthat would bepostgresby default. What do you think?This may close #196.