Pull request for battleship #5
Open
jonathanparrish wants to merge 23 commits intotiyd-rails-2015-01:masterfrom
Open
Pull request for battleship #5jonathanparrish wants to merge 23 commits intotiyd-rails-2015-01:masterfrom
jonathanparrish wants to merge 23 commits intotiyd-rails-2015-01:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I only got through test 26 fully and partially through 27. I guessed through a bunch and got help when the code was really screwy. Apparently I slimed a few tests and didn't know it, because when I got to T-18 things went south.
I feel fairly good about what is here, however I didn't get to finish. The readme didn't get done, but that was not going to be done until all of the code was finished.
JP