Does stuff with employees and monies.#12
Open
Rocky-R wants to merge 15 commits intotiyd-rails-2015-01:masterfrom
Open
Does stuff with employees and monies.#12Rocky-R wants to merge 15 commits intotiyd-rails-2015-01:masterfrom
Rocky-R wants to merge 15 commits intotiyd-rails-2015-01:masterfrom
Conversation
Contributor
|
Good commit messages (if not a bit vague with things like "Add test08". |
Contributor
There was a problem hiding this comment.
Classy use of reduce.
Contributor
|
Good work, Rocky. Very solid. The only slightly unusual part is the way that you distributed a department's raise. It brings up the question of why you chose 0.05 as a magic number while splitting up raises. That aside, great work. As you know, I think you're doing very well in the class. Let me know if you have any questions! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.