employee_review_pull

[pkthunda]

No description provided.

[masonfmatthews]

You set satisfactory to an array here, but you use it as a true/false elsewhere. It would probably be best to leave off this line to not confuse future developers (including yourself).

[pkthunda]

Thank you for the info! By the way, sorry if I did something wrong today. I
didn't understand exactly what you meant earlier after the mini lecture.
See you tomorrow and have a goodnight!

Parker
On Jan 28, 2015 9:20 PM, "Mason F. Matthews" notifications@github.com
wrote:

In employee.rb
#14 (comment)
:

@@ -0,0 +1,30 @@
+class Employee

• attr_accessor :name, :salary, :reviews, :satisfactory
• def initialize(name, salary)
• @name = name
• @salary = salary
• @reviews = []
• @satisfactory = []

You set satisfactory to an array here, but you use it as a true/false
elsewhere. It would probably be best to leave off this line to not confuse
future developers (including yourself).

—
Reply to this email directly or view it on GitHub
https://github.com/tiyd-rails-2015-01/employee_reviews/pull/14/files#r23742538
.

[masonfmatthews]

Parker -

Good work on this assignment. I made a few notes, but I think they all revolved around the same thing. The use of two instance variables to capture the same thing was giving you trouble.

I'm guessing you also realize that your git commit messages are a bit informal (which is fun, but not how you eventually want to be writing them).

My only other concern would be the lack of any methods for setting a departmental raise. Did you run out of time on that one? Did you try it and back out the attempt? How did that all go?

Thanks!

[pkthunda]

Mason,
Thanks for the feedback. It is extremely useful! I will alter my git
commit messages as well. I did run out of time for the give_raise I was
attempting after battling with it for quite a long time, and decided to get
some sleep instead. Thanks again for the homework review. See you in the
morning.

Best,
Parker

On Wed, Jan 28, 2015 at 9:28 PM, Mason F. Matthews <notifications@github.com

wrote:

Parker -

Good work on this assignment. I made a few notes, but I think they all
revolved around the same thing. The use of two instance variables to
capture the same thing was giving you trouble.

I'm guessing you also realize that your git commit messages are a bit
informal (which is fun, but not how you eventually want to be writing them).

My only other concern would be the lack of any methods for setting a
departmental raise. Did you run out of time on that one? Did you try it and
back out the attempt? How did that all go?

Thanks!

—
Reply to this email directly or view it on GitHub
#14 (comment)
.

[pkthunda]

Hello everyone,

This is for one of the most amazing people I've ever met in my
life- my sister Renee Welch. Renee is my sister, my role model, and one
of my best friends. She is a fighter and deserves the best. I know I
can only impact MS one small step at a time, but I hope to see the day
where we beat MS completely. I hope that you join and help me. 1love.

Why I Participate:
Walk MS is a day that connects friends, families, and coworkers who
join together to help create a world free of MS. Each step we take
brings us closer to ending MS forever. That’s why I registered
for Walk MS.

About MS
Multiple sclerosis, an unpredictable, often disabling disease of the
central nervous system, interrupts the flow of information within the
brain, and between the brain and body. Symptoms range from numbness and
tingling to blindness and paralysis. The progress, severity and
specific symptoms of MS in any one person cannot yet be predicted, but
advances in research and treatment are moving us closer to a world free
of MS. Most people with MS are diagnosed between the ages of 20 and 50,
with at least two to three times more women than men being diagnosed
with the disease. MS affects more than 2.3 million worldwide.

Please support me!
Your gift helps provide life-changing programs and services for people
affected by MS, and cutting-edge research. Your donation puts us closer
to realizing our promise to STOP MS in its
tracks, RESTORE lost function and END MS forever.
Ending MS means no one will receive an MS diagnosis again.

Every step matters. Every dollar counts. Every person makes a
difference.

Please visit National MS Society today!

Click here to visit my personal page.
If the text above does not appear as a clickable link, you can visit the web address:
http://main.nationalmssociety.org/site/TR?px=13956200&pg=personal&fr_id=25220&et=btzFErgCWa0uPLcdUwKy7A

If you no longer wish to receive email messages sent from your friends on behalf of this organization, please follow the link below: http://main.nationalmssociety.org/site/TellFriendOpt?action=optout&toe=c3fe6cf4948541b3977eba8bcbb0f53df959042494d93ffbc286acd0e6fccd8c9ed88a991e44bc776cc64ba9051ab77ac8d1febaf2b2156ad2a9e023242c99d9e155e6f3aa0c9f83ab5d9721e19230256e63de2f877e0159db5c211a23dfdc66a11711f2a52522d69110a3fc73043c69

National MS Society |
http://www.nationalmssociety.org/index.aspx

Forward to a Friend |
http://main.nationalmssociety.org/site/TellAFriend

Privacy Policy |

http://www.nationalmssociety.org/legal-notice-privacy-policy/index.aspx

Unsubscribe

http://main.nationalmssociety.org/site/CO?s_AffiliateSecCatId=1&pw_id=12021

733 Third Avenue, New York, New York 10017 | 1-800-FIGHT-MS (344-4867)

FOLLOW US 

Facebook

 

Twitter

 

YouTube

 

LinkiedIn

 

Blogger

 

Flickr

 

MS Connection

https://www.facebook.com/nationalmssociety
https://twitter.com/mssociety
http://www.youtube.com/nationalmssociety
http://www.linkedin.com/company/national-ms-society
http://www.msconnection.org/Blog
http://www.flickr.com/photos/nationalmssociety
http://www.msconnection.org