Employee Review Assignment#15
Open
chrisfoster22 wants to merge 22 commits intotiyd-rails-2015-01:masterfrom
chrisfoster22:master
Open
Employee Review Assignment#15chrisfoster22 wants to merge 22 commits intotiyd-rails-2015-01:masterfrom chrisfoster22:master
chrisfoster22 wants to merge 22 commits intotiyd-rails-2015-01:masterfrom
chrisfoster22:master
Conversation
Contributor
|
Your commit messages are definitely consistent, which is nice. Don't forget long-term, though: present tense singular. |
Contributor
|
Chris - Very good code; thanks. My only concern is your use of strings to store numbers; things will be much easier if you just use plain-old numbers for those parameters. I think that you're doing well in the class, but if you have any questions or concerns, please let me know. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.