Homework due Tuesday 1/27#2
Open
katiebuilds wants to merge 14 commits intotiyd-rails-2015-01:masterfrom
Open
Conversation
Contributor
There was a problem hiding this comment.
When you commit code, it's good to have cleaned out all commented lines like this first. If you've used git properly, these sorts of things will be present in your git history if you ever need to pull them out.
Contributor
|
Katie - Your code rocks, and I appreciate that you've used so many techniques that we've talked about in class (modules, etc). You're doing great work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Soooo I had every intention of using Regular Expressions, but I started writing the method with the arrays of keywords, and then suddenly, I didn't end up using them at all. Oops! One, uncertain how I could have used Regex (as I feel we are in this case mainly looking for whole words and not parts of words), and two, would be curious to see how my method works on reviews that are a little more subtle.