Conversation
There was a problem hiding this comment.
Great parameter variable name.
On the flipside, I'd suggest using full words in variable and method names, though. "department_raise" is better.
There was a problem hiding this comment.
Actually, you could just call it "raise", as it's already in the context of a department.
|
Owen - Your code is good, and your testing strategy is correct as well. I think you write a bit more code than you need to, and your concepts are stomping on each other a bit (e.g. you stick a bit more under attr_accessor than makes sense), but you are certainly getting the job done. I think the nuances will continue to accumulate for you over time. If you have any concerns that you'd like to discuss, just let me know. Otherwise, I think that you're right on track for the class. |
No description provided.