Implement half of tests in Bats#1187
Merged
spacewander merged 10 commits intotj:mainfrom Mar 12, 2025
Merged
Conversation
da8d8f8 to
26bd63f
Compare
26bd63f to
de55275
Compare
spacewander
reviewed
Nov 29, 2024
Collaborator
spacewander
left a comment
There was a problem hiding this comment.
Could we add a job in the CI to run the bats test? For now, we can run both py and shell until everything is done.
Collaborator
|
Great! pls replace the ci git-extras/.github/workflows/ci.yml Line 56 in fdaca2c with the bats, that makes everything done easily. |
Collaborator
Author
|
It's done! :) cc @vanpipy |
spacewander
reviewed
Mar 10, 2025
Collaborator
spacewander
left a comment
There was a problem hiding this comment.
The CI is broken: https://github.com/tj/git-extras/actions/runs/13717005098
Collaborator
Author
|
Interestingly, GitHub doesn't clearly show that CI failed to run! It shows all green for me and the only difference is the omission of the "All checks have passed" text. I guess this is part of the new pull request status box they recently rolled out... I made those changes 👍 |
spacewander
approved these changes
Mar 12, 2025
Collaborator
|
Merged. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This supersedes #1170. As mentioned in the issue that the PR links to, the testing suite is being converted from Pytest to Bash, mostly due to Pytest's poor support for Bash codecov.
I changed the formatting for files in
bats/because they use a lot of heredocs for improved readability of the stdout content assertions. According to the Bash manual (emphasis mine):This adds the first half of tests just to get things started. The suite can be ran with:
In another PR, I'll rewrite the other half of tests, add documentation, and eventually remove the pytest stuff.
For a more detailed explanation of functions and commands (for those not as familiar with Bats), #1170 contains very verbose details in comments