Allow to use a seeded random for word generation#12
Open
dhontecillas wants to merge 8 commits intotjarratt:masterfrom
Open
Allow to use a seeded random for word generation#12dhontecillas wants to merge 8 commits intotjarratt:masterfrom
dhontecillas wants to merge 8 commits intotjarratt:masterfrom
Conversation
Bumps [golang.org/x/net](https://github.com/golang/net) from 0.8.0 to 0.33.0. - [Commits](golang/net@v0.8.0...v0.33.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
…/net-0.33.0 Bump golang.org/x/net from 0.8.0 to 0.33.0
Bumps [golang.org/x/net](https://github.com/golang/net) from 0.33.0 to 0.36.0. - [Commits](golang/net@v0.33.0...v0.36.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
…/net-0.36.0 Bump golang.org/x/net from 0.33.0 to 0.36.0
Bumps [golang.org/x/net](https://github.com/golang/net) from 0.36.0 to 0.38.0. - [Commits](golang/net@v0.36.0...v0.38.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-version: 0.38.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
…/net-0.38.0 Bump golang.org/x/net from 0.36.0 to 0.38.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some cases is useful to have a deterministic / reproducible sequence of random generated words, and with this PR we add a new constructor function:
NewBabblerWithRand, so we can provide an initialized random generator, to generate the words.Also, since the non-global random generator in go is not thread-safe, a Mutex (a write one because the random objects gets updated when we request a number) is added to the call that returns a a string.
With this PR we do not break any existing API contract or functionality, and existing apps can keep having previous non deterministic.