Fix the issue #51 that crashed the server on Linux.#52
Open
brnrd wants to merge 1 commit intotjfontaine:masterfrom
Open
Fix the issue #51 that crashed the server on Linux.#52brnrd wants to merge 1 commit intotjfontaine:masterfrom
brnrd wants to merge 1 commit intotjfontaine:masterfrom
Conversation
Collaborator
|
This project is no longer maintained, but we are happy to link to a well maintained fork. Please see: #111 |
|
@brnrd I'm looking and noticing that the |
Author
|
@fastest963 @taoeffect Since this was posted almost 3 years ago, I'm not sure this is still an issue. And sadly, I don't have the time now to debug it. This PR could be closed if that's ok with you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this slight change, a Node.js server that imports the module still works with Windows but now works too with Linux.
The hosts object contains a _store that's an object containing itself a _store. The access to the second one was missing.
{ _zone: '.',
_store:
{ _store: { _store: [Object] }, <----
_zone: '.',
_max_keys: undefined,
_ttl: { length: 0, root: undefined, _comparator: [Function] } },
purge: [Function] }
It would solve the issue #51 and it would be great to push it to NPM as well.
Thanks.