Skip to content

implementation of media list#11

Open
npenin wants to merge 4 commits intotjfontaine:masterfrom
npenin:master
Open

implementation of media list#11
npenin wants to merge 4 commits intotjfontaine:masterfrom
npenin:master

Conversation

@npenin
Copy link

@npenin npenin commented Apr 3, 2015

Hi,

After your great work, I had to revamp some features and add some for my personnal project. Here is what I did. Feel free to integrate it in your project.

Nicolas.

npenin and others added 4 commits July 7, 2013 12:19
- started to factorize event code
- added medialist and medialist player
handled null media
@bradparks
Copy link

@npenin - as a slight aside, i've tried to use node-vlc and your PR, and haven't been able to get it to build... I get

$ node examples/vlc.js                                                                                                                              17:37:42
/Users/bparks/gitrepos/node-vlc/node_modules/ffi/lib/_foreign_function.js:36
      throw new TypeError('Expected ' + numArgs +
            ^
TypeError: Expected 2 arguments, got 1
    at Object.ForeignFunction.proxy [as libvlc_media_new_as_node] (/Users/bparks/gitrepos/node-vlc/node_modules/ffi/lib/_foreign_function.js:36:13)
    at new module.exports (/Users/bparks/gitrepos/node-vlc/lib/media.js:107:25)
    at mediaFromFile (/Users/bparks/gitrepos/node-vlc/vlc.js:107:12)
    at Object.<anonymous> (/Users/bparks/gitrepos/node-vlc/examples/vlc.js:10:17)
    at Module._compile (module.js:460:26)
    at

I've tried using Node 0.10 and 0.12, and doing an npm rebuild each time, but no luck... Do you know what I'm doing wrong?

@npenin
Copy link
Author

npenin commented Apr 27, 2015

Maybe a different version of ffi. As you can see, I coded it 1 year ago. Maybe there is some new apis in ffi. This could also be a vlc api that has changed.

It could also happen if you did not created you media player before...

@bradparks
Copy link

cool.... thanks for the info! much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants