Implement TryFrom<GitUrl> for url::Url

[dzuelke]

GitUrl::url_compat_display() is currently private, but it would be very useful to have this functionality - in my case, normalizing an SSH style URL is fine, especially because I do not want to bother with handling the 'url lifetime of GitUrl in my wrapper enum.

This change implements fallible conversion to url::Url for GitUrl and &GitUrl via GitUrl::url_compat_display().

Longer term it might be wise to re-visit the use of a lifetime for the purpose of re-using slices of the input string - the url::Url crate does not bother with such micro-optimizations either, presumably for good reasons.

Obviously, to use a GitUrl as a url::Url, the conversion to url::Url still has to happen twice (because GitUrl::parse() incurs the conversion via GitUrl::is_valid()), but that can be optimized in a separate change, e.g. via a new GitUrl::parse_to_url(), or by removing the conversion from GitUrl::is_valid() altogether, leaving it to the caller to attempt the conversion.

[tjtelan]

GitUrl::parse_to_url() was originally planned, but didn't make it in this latest effort. I'll add it into the backlog.

Ideally, I'd like to enhance the overall quality of the parsing to the point where I can remove url from the default features, making it easier for users to include url only when it's more convenient for their needs.

In the meantime, converting to url::Url is intended as a temporary solution until I have more time to improve error handling during parsing, so I can provide more accurate feedback to users, which is something url::Url handles more reliably.

Longer term it might be wise to re-visit the use of a lifetime for the purpose of re-using slices of the input string - the url::Url crate does not bother with such micro-optimizations either, presumably for good reasons.

I appreciate this feedback. This is fair, and worth a review in the future.

Thanks for your time and the contribution!

[dzuelke]

Thank you for the super quick merge and release, very much appreciated!