Remove lifetime from GitUrl #72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
tjtelan
pushed a commit
that referenced
this pull request
Sep 18, 2025
## 🤖 New release
* `git-url-parse`: 0.5.3 -> 0.6.0 (⚠ API breaking changes)
### ⚠ `git-url-parse` breaking changes
```text
--- failure type_mismatched_generic_lifetimes: type now takes a different number of generic lifetimes ---
Description:
A type now takes a different number of generic lifetime parameters. Uses of this type that name the previous number of parameters will be broken.
impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.43.0/src/lints/type_mismatched_generic_lifetimes.ron
Failed in:
Struct GitLabProvider (1 -> 0 lifetime params) in /tmp/.tmp4cEC5b/git-url-parse-rs/src/types/provider/gitlab.rs:51
Struct GenericProvider (1 -> 0 lifetime params) in /tmp/.tmp4cEC5b/git-url-parse-rs/src/types/provider/generic.rs:41
Struct GitUrl (1 -> 0 lifetime params) in /tmp/.tmp4cEC5b/git-url-parse-rs/src/types/mod.rs:48
Struct GitUrl (1 -> 0 lifetime params) in /tmp/.tmp4cEC5b/git-url-parse-rs/src/types/mod.rs:48
Struct AzureDevOpsProvider (1 -> 0 lifetime params) in /tmp/.tmp4cEC5b/git-url-parse-rs/src/types/provider/azure_devops.rs:42
```
<details><summary><i><b>Changelog</b></i></summary><p>
<blockquote>
##
[0.6.0](v0.5.3...v0.6.0)
- 2025-09-18
### Added
- Add interoperable support for `url::Url`
([#74](#74))
### Other
- Remove lifetime from GitUrl
([#72](#72))
</blockquote>
</p></details>
---
This PR was generated with
[release-plz](https://github.com/release-plz/release-plz/).
---------
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #69
&strtoStringimplto replace derived getters