Skip to content

rename __{update,touch}()#340

Merged
tkem merged 1 commit intotkem:dev/v6.0.0from
isidroas:rename_update
Apr 8, 2025
Merged

rename __{update,touch}()#340
tkem merged 1 commit intotkem:dev/v6.0.0from
isidroas:rename_update

Conversation

@isidroas
Copy link
Contributor

@isidroas isidroas commented Apr 6, 2025

dict.update() do another different task

dict.update() do another different task
@tkem
Copy link
Owner

tkem commented Apr 7, 2025

Do I understand you correctly, that you think __update sounds like dict.update, which does something else?
And that you suggest renaming that (private!) method, to avoid misunderstandings and confusion?

@tkem tkem changed the base branch from master to dev/v6.0.0 April 8, 2025 07:18
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (f504e1d) to head (b97fefb).
Report is 1 commits behind head on dev/v6.0.0.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##           dev/v6.0.0      #340   +/-   ##
============================================
  Coverage      100.00%   100.00%           
============================================
  Files               5         5           
  Lines             794       794           
============================================
  Hits              794       794           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tkem tkem merged commit 65b0d69 into tkem:dev/v6.0.0 Apr 8, 2025
7 checks passed
@isidroas
Copy link
Contributor Author

isidroas commented Apr 8, 2025

Thank you for merging!

The name is inspired by the Unix command. There's also a memcache command, though it's slightly different as it takes the expiration date as an argument

@tkem
Copy link
Owner

tkem commented Apr 8, 2025

@isidroas: Yes, after thinking about it, I liked your name much better than mine ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants