Skip to content

Improve GitHub Actions runtime#343

Closed
ddelange wants to merge 2 commits intotkem:masterfrom
ddelange:patch-2
Closed

Improve GitHub Actions runtime#343
ddelange wants to merge 2 commits intotkem:masterfrom
ddelange:patch-2

Conversation

@ddelange
Copy link
Contributor

@ddelange ddelange commented Apr 7, 2025

cherry-picked from #338

@ddelange ddelange requested a review from tkem April 8, 2025 11:35
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (f504e1d) to head (6c5721d).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #343   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          794       794           
=========================================
  Hits           794       794           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@@ -1,6 +1,14 @@
name: CI

on: [push, pull_request, workflow_dispatch]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Frankly, I'd rather keep it simple and as it is. I don't feel any urge to optimize anything here.

@ddelange ddelange closed this Apr 8, 2025
@ddelange ddelange deleted the patch-2 branch April 8, 2025 14:40
@tkem
Copy link
Owner

tkem commented Apr 8, 2025

Still, thanks for sharing - OTOH, the

 - run: python -m pip install coverage tox
 - run: python -m tox

look slightly odd, something I probably just copied from an older version of https://docs.github.com/en/actions/use-cases-and-examples/building-and-testing/building-and-testing-python#testing-your-code...

So if this works without python -m and you still can be bothered, a PR for these would be welcome - I could also remove it myself, but I don't deserve the praise for this ;-)

@ddelange
Copy link
Contributor Author

ddelange commented Apr 8, 2025

haha no worries about praise, feel free to steal it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants