syscalls: dereferencing syscall argument pointers, parsers for argument values (modified pr #1824)#1852
Draft
psolvx wants to merge 11 commits intotklengyel:mainfrom
Draft
syscalls: dereferencing syscall argument pointers, parsers for argument values (modified pr #1824)#1852psolvx wants to merge 11 commits intotklengyel:mainfrom
psolvx wants to merge 11 commits intotklengyel:mainfrom
Conversation
Collaborator
|
Can one of the admins verify this patch? |
b493c66 to
e92e096
Compare
…argument pointers and output the actual value
87c937f to
524b1ee
Compare
Contributor
Author
|
This is another approach I tried, where instead of a runtime argument parser lookup a pointer to the parser is added to arg_t at plugin initialization. Complexity diff is from: which I don't know how to easily refactor |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modified idea from #1824 by @1ndahous3, so most of that pr is included, with some changes.
fill_fmt_args uses parsers specified by:
Subkeys from #1850 are used to have a
"Arguments"and"Extra"subkeys. Parsers can modify output argument values or add data to"Extra"subkey.There are 2 boolean options:
--syscall-nested-args- controls if arguments are nested in an"Arguments"subkey--syscall-dereference-args- controls if argument pointers are dereferenced and enables extra parsers (the goal was for the default setting to leave only parsers corresponding to previous parse_argument and win_extract_string functions, its up to each parser to respect that)With both of these flags disabled output format should be backwards compatible
New parsers allow for reading:
This pr is based on #1850 and also #1851 (though this one is not strictly necessary)