scanner: remove erroneous array_delete on const parameter#143
Merged
ahelwer merged 1 commit intotlaplus-community:mainfrom Feb 17, 2026
Merged
scanner: remove erroneous array_delete on const parameter#143ahelwer merged 1 commit intotlaplus-community:mainfrom
ahelwer merged 1 commit intotlaplus-community:mainfrom
Conversation
Contributor
|
@ahelwer (the parser fails to generate on the latest tree-sitter |
Contributor
|
@ahelwer friendly ping; this is blocking upstream CI, so this would be great to get in sooner rather than later. |
Contributor
|
Thanks! Sorry for the wait. |
Contributor
|
No worries, and thank you! |
Contributor
Author
|
thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: https://github.com/tree-sitter/tree-sitter/actions/runs/21795611628/job/62882578559?pr=5309#step:10:252
The old
array_deletemacro silently stripped the const qualifier, but the change in tree-sitter/tree-sitter#5309 expands the macro to also set the contents toNULL, which the compiler rejects. Also, the caller already callsarray_deleteafterparse_proof_step_idreturns, so this was technically a double-free with no side effects as the contents were already set toNULL.