Skip to content

Remove unnecessary activation events#356

Merged
FedericoPonzi merged 1 commit intotlaplus:masterfrom
hwayne:clean-activationevents
Dec 20, 2024
Merged

Remove unnecessary activation events#356
FedericoPonzi merged 1 commit intotlaplus:masterfrom
hwayne:clean-activationevents

Conversation

@hwayne
Copy link
Contributor

@hwayne hwayne commented Dec 20, 2024

Whenever I open the extension, vscode complains that commands don't need to be added to activationEvents.

image

This PR fixes that terrible oversight. The extension works normally without them.

Whenever I open the extension, vscode complains that commands don't need to be added to activationEvents. This commit fixes that terrible oversight.

Signed-off-by: Hillel <h@hillelwayne.com>
@FedericoPonzi FedericoPonzi merged commit 3731be5 into tlaplus:master Dec 20, 2024
4 checks passed
@lemmy
Copy link
Member

lemmy commented Dec 21, 2024

For the record, there was a bug where the TLA+ commands of the extension wouldn’t appear unless some .tla file was opened in the editor. Consequently, it became impossible to use the REPL alone. However, I don’t seem to be able to reproduce this issue anymore. Therefore, I’m leaving it here just because this issue is about activation and in case the problem resurfaces.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants