Fix merged stream end timing #466
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Y <[email protected]>
lemmy
reviewed
Nov 26, 2025
src/tla2tools.ts
Outdated
| process.once('close', endMerged); | ||
| // If process already exited, end stream now (calling end() twice is safe) | ||
| // If the process already exited before listeners are attached, end the merged | ||
| // stream on the next tick so late subscribers still observe the `end` event. |
Collaborator
Author
There was a problem hiding this comment.
in the Nodejs the terminology: a "tick" is one complete iteration of the event loop (Timers => Poll => Check)
We use setImmediate to defer execution to the "Check" phase of the loop (unlike process.nextTick which runs immediately). This guarantees the current synchronous stack finishes — allowing the listener to attach — before the event is actually emitted.
for reference https://nodejs.org/en/learn/asynchronous-work/event-loop-timers-and-nexttick#processnexttick-vs-setimmediate
Member
There was a problem hiding this comment.
This explanation is really helpful. I suggest incorporating it into the comment.
Collaborator
Author
There was a problem hiding this comment.
alright, just pushed a commit
FedericoPonzi
approved these changes
Nov 26, 2025
Signed-off-by: Y <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.