-
Notifications
You must be signed in to change notification settings - Fork 44
Automatically register TLA+ MCP server in VSCode. #472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR enables automatic discovery/registration of the TLA+ MCP server in VS Code, improves runtime logging, and updates configuration to support dynamic port assignment by default.
- Adds a VS Code MCP server definition provider to surface the running MCP server to the LM API.
- Changes the default MCP port to 0 (ephemeral) and removes Cursor-specific unconditional start logic.
- Improves log messages for registration/unregistration flows.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| src/main.ts | Removes Cursor-specific logic and retains a single flow that starts the MCP server when tlaplus.mcp.port is 0 or a valid port, aligning with new default behavior. |
| src/lm/MCPServer.ts | Registers/unregisters an MCP server definition provider in VS Code on server start/stop; refines log messages; tracks registration via a disposable. |
| package.json | Contributes mcpServerDefinitionProviders entry (with id/label) and changes tlaplus.mcp.port default to 0 with updated description. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
6c7faf7 to
58bb60d
Compare
- Introduced MCP server definition provider for VS Code. - Enhanced error logging for MCP server registration. - Updated MCP server port configuration to allow dynamic port assignment. - Removed redundant unconditional MCP server start logic for Cursor. Related: #470 [Feature] Signed-off-by: Markus Alexander Kuppe <[email protected]>
58bb60d to
0184d07
Compare
younes-io
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…hatmode files Related: tlaplus/vscode-tlaplus#472 Signed-off-by: Markus Alexander Kuppe <[email protected]>
Related:
[Feature]