Skip to content

Conversation

@lemmy
Copy link
Member

@lemmy lemmy commented Dec 2, 2025

  • Introduced MCP server definition provider for VS Code.
  • Enhanced error logging for MCP server registration.
  • Updated MCP server port configuration to allow dynamic port assignment.
  • Removed redundant unconditional MCP server start logic for Cursor.

Related:

[Feature]

@lemmy lemmy added enhancement New feature or request AI Work related to TLAi+ labels Dec 2, 2025
@lemmy lemmy requested a review from Copilot December 2, 2025 17:34
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enables automatic discovery/registration of the TLA+ MCP server in VS Code, improves runtime logging, and updates configuration to support dynamic port assignment by default.

  • Adds a VS Code MCP server definition provider to surface the running MCP server to the LM API.
  • Changes the default MCP port to 0 (ephemeral) and removes Cursor-specific unconditional start logic.
  • Improves log messages for registration/unregistration flows.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

File Description
src/main.ts Removes Cursor-specific logic and retains a single flow that starts the MCP server when tlaplus.mcp.port is 0 or a valid port, aligning with new default behavior.
src/lm/MCPServer.ts Registers/unregisters an MCP server definition provider in VS Code on server start/stop; refines log messages; tracks registration via a disposable.
package.json Contributes mcpServerDefinitionProviders entry (with id/label) and changes tlaplus.mcp.port default to 0 with updated description.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@lemmy lemmy force-pushed the mku-CodeRegMCPProg branch from 6c7faf7 to 58bb60d Compare December 2, 2025 17:54
- Introduced MCP server definition provider for VS Code.
- Enhanced error logging for MCP server registration.
- Updated MCP server port configuration to allow dynamic port assignment.
- Removed redundant unconditional MCP server start logic for Cursor.

Related: #470

[Feature]

Signed-off-by: Markus Alexander Kuppe <[email protected]>
Copy link
Collaborator

@younes-io younes-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lemmy lemmy merged commit 249065f into master Dec 2, 2025
4 checks passed
@lemmy lemmy deleted the mku-CodeRegMCPProg branch December 2, 2025 18:21
lemmy added a commit to lemmy/lamport-agent that referenced this pull request Dec 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI Work related to TLAi+ enhancement New feature or request

Development

Successfully merging this pull request may close these issues.

2 participants