Fix formatter failing on specs that EXTENDS CommunityModules#496
Merged
FedericoPonzi merged 1 commit intotlaplus:masterfrom Feb 15, 2026
Merged
Fix formatter failing on specs that EXTENDS CommunityModules#496FedericoPonzi merged 1 commit intotlaplus:masterfrom
FedericoPonzi merged 1 commit intotlaplus:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where the TLA+ formatter fails when processing specifications that EXTEND CommunityModules. The fix switches from using -jar to -cp (classpath) when invoking the formatter, allowing both tlaplus-formatter.jar and CommunityModules-deps.jar to be on the classpath simultaneously.
Changes:
- Modified Java invocation to use
-cpwith explicit main class instead of-jar - Added CommunityModules-deps.jar to the formatter's classpath
- Updated documentation comments to reflect the new classpath-based approach
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Switch from -jar to -cp so CommunityModules-deps.jar is on the classpath. Signed-off-by: Federico Ponzi <me@fponzi.me>
FedericoPonzi
force-pushed
the
fponzi/formatter-cm
branch
from
e65d5a6 to
b46e987
Compare
lemmy
approved these changes
Feb 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch from -jar to -cp so CommunityModules-deps.jar is on the classpath. Tested with reformatting of specifications/ewd998/EWD998.tla. I have a folder with tlapm and community modules in a libs folder and the path configured in the settings.
Ref comment: #327 (comment)