Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR maybe adds eagerly-updated 'push' nodes, which can be used selectively to avoid traversing sections of the graph, and to set historyLength to 1 in some cases.
when you call atom.set, whether in a transaction or not, if the atom has any direct 'push' children, those children will be updated immediately. And if those children have any direct 'push' children they will also be updated immediately, and so on.
Then when the final reaction sweep is done when the root transaction commits, if a push node is encountered which did not change during the transaction, it is not traversed.
Before merging:
numPushyChildrento atoms/computeds to allow avoiding push traversal. Or maybe use a separate lazily-instantiated ArraySet?