chore: replace is-ci with native process.env.CI check#90
Open
roli-lpci wants to merge 2 commits intotldraw:mainfrom
Open
chore: replace is-ci with native process.env.CI check#90roli-lpci wants to merge 2 commits intotldraw:mainfrom
roli-lpci wants to merge 2 commits intotldraw:mainfrom
Conversation
Replace the `is-ci` package with a direct `process.env.CI` check. The `CI` environment variable is set by GitHub Actions, GitLab CI, CircleCI, Travis, and all major CI providers. - Remove `is-ci` from devDependencies - Remove `@types/is-ci` from devDependencies - Replace import with `const isCI = !!process.env.CI` Dependency reduction: -3 packages (is-ci + @types/is-ci + ci-info transitive) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
@roli-lpci is attempting to deploy a commit to the tldraw Team on Vercel. A member of the Team first needs to authorize it. |
Use strict equality check instead of double-bang coercion to avoid treating CI=false as truthy (non-empty string). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
is-cipackage with nativeprocess.env.CIcheckis-ciand@types/is-cifrom devDependenciesCIenvironment variable is set by all major CI providers (GitHub Actions, GitLab CI, CircleCI, Travis, etc.)Changes
scripts/build-api.ts—import isCI from 'is-ci'→const isCI = !!process.env.CIpackage.json— removedis-ciand@types/is-cifrom devDependenciesTesting
process.env.CIis truthy in CI environments (same detection asis-ci)Context: The e18e community tracks this pattern at ecosystem-issues#128 —
is-ciis a thin wrapper aroundci-info.isCI, which itself checksprocess.env.CI.