Improve test coverage for de.rub.nds.crawler package#37
Open
Conversation
- Add comprehensive tests for CommonMain covering all branches - Add Mockito dependencies for mocking - Create test resources (targets.txt and scanDefinition.json) - Test both controller and worker command paths - Test error cases for invalid commands
- Add comprehensive tests for CommonMain covering 94% of the class - Add Mockito dependency for mocking external dependencies - Create test resources (targets.txt and scanDefinition.json) - Test both controller and worker command paths - Test error cases for invalid and missing commands - Improve overall package coverage from 0% to 94%
- Add comprehensive tests for CruxListProvider achieving 100% coverage - Test various input scenarios including valid and invalid formats - Test filtering of HTTPS vs HTTP entries and rank boundaries - Improve targetlist package coverage from 10% to 27%
- Add comprehensive tests for DenylistFileProvider achieving 100% coverage - Test domain, IP, and subnet denylist functionality - Test handling of invalid entries and non-existent files - Test thread safety with concurrent access - Improve denylist package coverage from 0% to 100%
- Test construction with ScanJobDescription - Test construction with invalid TO_BE_EXECUTED status - Test fromException method with various error statuses - Test ID getter and setter functionality - Test all getters with populated data - Achieve 100% coverage for ScanResult class
- Add test for CommonMain constructor - Achieve 97% coverage for de.rub.nds.crawler package - Note: Default case in switch is unreachable in normal operation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary