[AI] Fix timeout issue during connection establishment (#193) #218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added serverSocket.setSoTimeout() before accept() call to prevent indefinite blocking when no client connects. This ensures the server times out appropriately and throws a SocketTimeoutException. - Set serverSocket timeout before calling accept() - Added test to verify timeout behavior works correctly - Fixes issue where server would hang indefinitely waiting for connections
ic0ns
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
serverSocket.accept()was blocking indefinitely when no client connectedserverSocket.setSoTimeout()before theaccept()call to ensure proper timeout handlingChanges
ServerTcpTransportHandler.initialize()to set socket timeout before accepting connectionstestAcceptTimeout()test to verify thatSocketTimeoutExceptionis thrown when no client connects within the timeout periodTest Plan
mvn test -Dtest=ServerTcpTransportHandlerTest- all tests passmvn spotless:applyFixes #193