[AI] Fix NPE in PreSharedKeyExtensionMessage for TLS 1.3 PSK handshake #219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PreSharedKeyExtensionMessage.copyPskSets method was not setting the identity field in PSKIdentity objects, causing a NullPointerException when the PreSharedKeyExtensionHandler tried to access the identity value during TLS 1.3 PSK handshakes. This fix ensures that the identity field is properly set when copying PSK sets, allowing TLS 1.3 PSK handshakes to complete successfully. Also fixed initialization of identities and binders lists in the Config constructor to prevent NPE when no PSK sets are configured. Added comprehensive unit tests to verify the fix works correctly. Fixes #188
ic0ns
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Description
The issue reported in #188 was caused by the
copyPskSetsmethod inPreSharedKeyExtensionMessagenot setting theidentityfield inPSKIdentityobjects. This caused a NullPointerException whenPreSharedKeyExtensionHandlertried to accesspskIdentity.getIdentity().getValue()during TLS 1.3 PSK handshakes.The fix adds the missing line:
Additionally, I found and fixed another issue where the
identitiesandbinderslists were not initialized in the Config constructor when no PSK sets were configured, which could lead to NPEs in other scenarios.Test plan
Fixes #188