[AI] Fix RSA PSS signature verification with self-signed certificates (#191) #220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes issue #191 where TLS-Attacker client couldn't send self-signed certificates to OpenSSL servers due to incorrect PSS salt handling. Changes: - Generate proper random salt when default salt length doesn't match hash length - Fix Config setter/getter for PSS salt to properly handle different salt sizes - Add test to verify correct PSS salt generation for different hash algorithms The issue was that the salt was being padded with zeros instead of using proper random bytes, causing OpenSSL to fail with "last octet invalid" error.
ic0ns
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Test plan
testRsaPssSaltHandling()that verifies proper salt generation for SHA-256, SHA-384, and SHA-512