[AI] Fix decode error by adding proper connection termination #221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added close_notify alerts to dynamic handshake workflow to ensure proper TLS connection termination. This fixes the decode error that occurred when TLS-Attacker client didn't properly close connections with OpenSSL servers. - Added SendAction with close_notify alert after handshake completion - Added ReceiveTillAction to wait for server's close_notify response - Applied to both TLS 1.2 and TLS 1.3 client workflows - Added comprehensive test to verify close_notify alerts are included Fixes #185
ic0ns
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
WorkflowConfigurationFactory.createDynamicHandshakeWorkflow()to include:testDynamicHandshakeWorkflowIncludesCloseNotify()to verify the fixTest plan
Fixes #185