Fix issue #78: Make AnotherName inner value configurable #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implemented AnotherNamePreparator to handle creating the value based on the configured value - Added X509Utf8String wrapper class to make Asn1Utf8String compatible with X509Component interface - AnotherName now supports configuring the inner value via setConfiguredValue() - Added comprehensive tests for AnotherNamePreparator - The inner value is currently implemented as UTF8String and can be extended to support other types based on the OID
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Details
This PR fixes issue #78 from the X509-Attacker-Development repository. The AnotherName class previously had a TODO comment indicating that the inner value should be preset from the config. This implementation allows users to configure the inner value of AnotherName.
The implementation currently supports UTF8String as the inner value type, which can be extended in the future to support other types based on the OID.
Test plan
Fixes tls-attacker/X509-Attacker-Development#78