Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implement an MPC protocol for computing TLS 1.3 key schedule. To accommodate it, I also made changes in the existing TLS 1.2 PRF.
Notable changes:
Isolate all HMAC-related functionality into a separate module, so that we don't leak the
inner/outer_partialterminology outside of that module.Modified TLS 1.2 PRF to use the
Hmacmodule.Streamlined
flush()logic in hopes of making the protocol easier to reason about. Now all sub-functionalities are flushed unconditionally.Added the
is_complete()method to all functionalities since relying on!wants_flush()proved not to be robust enough.