Conversation
tmarhguy
added a commit
that referenced
this pull request
Jan 16, 2026
…tests-wgn8aw ci: switch firmware formatting to clang-format and add test-vector validation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
clang-formatto provide a reproducible, installable formatter for.inofiles.Description
.github/workflows/ci.ymlto installjsonschemaandclang-format==18.1.5, runtools/validate_test_vectors.py, and runclang-format --dry-run --Werror --style=fileagainst all*.inofiles..clang-formatstyle file to define formatting rules and updatedREADME.mdwith local validation commands using pinned tool versions.test/schema/test-vector.schema.jsonandtools/validate_test_vectors.py, plus atest/vectors/.gitkeepplaceholder, to validate JSON test vectors.miscellaneous/firmware/controller-display/controller_display.inoandmiscellaneous/firmware/controller-input/controller_input.inoto satisfy the formatter.Testing
verifyjob had previously failed on the branch before these formatting changes, and CI has not been re-run since switching toclang-format.tools/validate_test_vectors.pyscript is included and will return non-zero on validation or JSON parse errors, causing CI to fail when invalid vectors are present.README.mdso developers can run the same checks prior to opening a PR.Codex Task