fix: set write deadline before writing messages#31
Open
alvarowolfx wants to merge 1 commit intotmc:masterfrom
Open
fix: set write deadline before writing messages#31alvarowolfx wants to merge 1 commit intotmc:masterfrom
alvarowolfx wants to merge 1 commit intotmc:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was having some weird behavior here when I set up ping/pong to keep the connection alive, where even with that, I was getting disconnected after some time.
Them I checked gorilla/websocket sample on how to keep the connection alive and noticed that their base samples resets the WriteDeadline on every write, this way keeping the connection alive.
https://github.com/gorilla/websocket/blob/master/examples/chat/client.go#L91
So this commit added that behavior.