Skip to content

feat!: alternative units and ingredients #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
tmlmt wants to merge 44 commits into
base: ci/pre-release
Choose a base branch
from
Draft

feat!: alternative units and ingredients #80

tmlmt wants to merge 44 commits into from

Conversation

@tmlmt
Copy link
Owner

@tmlmt tmlmt commented Jan 6, 2026 •
edited
Loading

Description

Introduction of alternative units and ingredients

Resolves: #66

Resolves: #69

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

@tmlmt Graphite App
Copy link
Owner Author

tmlmt commented Jan 6, 2026 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@tmlmt tmlmt mentioned this pull request Jan 6, 2026
Draft
4 tasks
@tmlmt tmlmt changed the title define types, define regex feat: Jan 6, 2026
@tmlmt tmlmt changed the title feat: feat!: alternative units and ingredients Jan 6, 2026
@tmlmt tmlmt force-pushed the feat/alt-units-and-ingredients branch from d8e738f to d24e9a0 Compare January 9, 2026 20:31
@tmlmt tmlmt mentioned this pull request Jan 9, 2026
Draft
4 tasks
@tmlmt tmlmt force-pushed the feat/alt-units-and-ingredients branch from d24e9a0 to 78a9f15 Compare January 9, 2026 21:09
@tmlmt tmlmt changed the base branch from v3 to graphite-base/80 January 11, 2026 03:27
@tmlmt tmlmt force-pushed the feat/alt-units-and-ingredients branch from 78a9f15 to d4637e7 Compare January 11, 2026 03:27
@tmlmt tmlmt changed the base branch from graphite-base/80 to docs/multiversion January 11, 2026 03:27
This was referenced Jan 11, 2026
Draft
Draft
Draft
tmlmt added 26 commits January 11, 2026 12:34
@tmlmt
increase coverage and fix along the way
99f0066
@tmlmt
chore: remove duplicate and wrongly names NestedAndGroup type
67f219b
@tmlmt
refactor: move isValueIntegerLike to type_guards
1ff055c
@tmlmt
test: increase coverage
b9c650c
@tmlmt
refactor: include preservation of integerProtected flag in resolveUnit
8d10f81
@tmlmt
chore: remove useless reference to __no-unit__
7005535
@tmlmt
fix(sortUnitList): no-unit ranked higher than integer-protected units
e774763
@tmlmt
chore: ensure consistant sorting regardless of host locale
32e6502
@tmlmt
test: add more tests for quantities/alternatives.ts
65fd58d
@tmlmt
fix(parsing): ingredient name and groupkey not detected for alternati…
798e331 
…ves with groupkey
@tmlmt
test(shoppingList): maximize coverge
8309a01
@tmlmt
fix(parsing): ingredient-recipe anchor for alternative ingredients wi…
928a37b 
…th groupkey
@tmlmt
fix(parsing): alternatives of ingredient items should not contain itemId
a356440
@tmlmt
style(regex): remove leading @ from in-line ingredient alternatives
6dab686
@tmlmt
chore: remove console.log
a7c3832
@tmlmt
chore(parsing): do not expect a note for ingredient alternatives with…
322f36e 
… group keys
@tmlmt
fix(parsing): alternative units not detected properly
56380eb
@tmlmt
fix(Recipe): clone function missing choices property
ec551ef
@tmlmt
reach 100% coverage and fix issues along the way
cf0493c
@tmlmt
feat(ProductCatalog): allow multiple product sizes
14e50de
@tmlmt
chore: authorize parcel and vue-demi with approve-builds
a1975ae
@tmlmt
chore(Recipe): hide _itemCount from instance properties
48445f5
@tmlmt
chore(gitignore): ignore .nuxt
048b7d4
@tmlmt
feat: show all options in ingredients list and enable calculating wit…
dc7f428 
…h options
@tmlmt
docs: add missing types and fine-tune docstrings
43404a7
@tmlmt
fix: add alternative units to ingredients list
1d2d5e5
@tmlmt tmlmt changed the base branch from docs/multiversion to graphite-base/80 January 11, 2026 18:30
@tmlmt tmlmt force-pushed the feat/alt-units-and-ingredients branch from d4637e7 to 1d2d5e5 Compare January 11, 2026 18:31
@tmlmt tmlmt changed the base branch from graphite-base/80 to ci/pre-release January 11, 2026 18:31
@tmlmt tmlmt mentioned this pull request Jan 11, 2026
Draft
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tmlmt