Skip to content

Drop support for Cucumber v1.3 #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Drop support for Cucumber v1.3 #135

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ jobs:
# Lowest and Latest version.
ruby: ['2.7', '3.3']
entry:
- { name: cucumber1_3, bats: test/cucumber.bats }
- { name: cucumber2_4, bats: test/cucumber.bats }
- { name: minitest5, bats: test/minitest5.bats }
- { name: rspec3, bats: test/rspec3.bats }
Expand Down
6 changes: 0 additions & 6 deletions Appraisals
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,5 @@
# frozen_string_literal: true

appraise 'cucumber1-3' do
gem 'cucumber', '~> 1.3.10'
# Pin Rake version to Prevent `NoMethodError: undefined method `last_comment'`.
gem 'rake', '< 11.0'
end

appraise 'cucumber2-4' do
gem 'cucumber', '~> 2.4.0'
# Pin Rake version to Prevent `NoMethodError: undefined method `last_comment'`.
Expand Down
11 changes: 0 additions & 11 deletions gemfiles/cucumber1_3.gemfile
View file
Open in desktop

This file was deleted.

6 changes: 1 addition & 5 deletions lib/test_queue/runner/cucumber.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,11 +56,7 @@ def run_worker(iterator)

@test_framework.cli.execute!(runtime)

if runtime.respond_to?(:summary_report, true)
runtime.send(:summary_report).test_cases.total_failed
else
runtime.results.scenarios(:failed).size
end
Copy link
Author

@S-H-GAMELINKS S-H-GAMELINKS May 14, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This conditional branch was specifically needed to support Cucumber v1.3.
Since support for that version has been removed, this code is no longer necessary.

runtime.send(:summary_report).test_cases.total_failed
end

def summarize_worker(worker)
Expand Down
Loading