Skip to content

Rename validation command in package.json from validate-all to validate-files for clarity. Update README.md to reflect the new command and provide additional context on the validation process. Modify GitHub Actions workflow to clarify that changes to registry.json won't trigger the build workflow, preventing infinite loops.#16

Merged
bthos merged 1 commit intomainfrom
Update-workflow
Feb 13, 2026

Conversation

@bthos
Copy link
Copy Markdown
Collaborator

@bthos bthos commented Feb 13, 2026

Signed-off-by: bthos el.mogul@outlook.es

Plugin Submission Checklist

  • Plugin ID follows format: author.plugin-name or lowercase-with-hyphens
  • Manifest passes npm run validate-plugins (or npm run validate-all)
  • SHA256 checksum verified (if distribution with checksums is used)
  • Plugin tested locally
  • README / docs updated if adding new author or changing structure
  • License is valid and specified
  • No malware or suspicious code

Type of Change

  • New plugin
  • Plugin update
  • Metadata fix
  • Documentation
  • Other (describe below)

Plugin Details (if applicable)

Plugin ID:
Version:
License:
Repository / Download URL:

DCO

By submitting this pull request, I certify that my contributions are made under the terms of the Developer Certificate of Origin. All commits are signed off with git commit -s.

…idate-files` for clarity. Update README.md to reflect the new command and provide additional context on the validation process. Modify GitHub Actions workflow to clarify that changes to `registry.json` won't trigger the build workflow, preventing infinite loops.

Signed-off-by: bthos <el.mogul@outlook.es>
Copilot AI review requested due to automatic review settings February 13, 2026 21:08
@bthos bthos merged commit 72c451a into main Feb 13, 2026
5 checks passed
@bthos bthos deleted the Update-workflow branch February 13, 2026 21:08
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves clarity in the validation workflow by renaming the validate-all command to validate-files and updating related documentation. It also simplifies the build-registry.yml workflow by removing a post-merge validation check and relying on path filtering to prevent infinite workflow loops.

Changes:

  • Renamed npm script from validate-all to validate-files for better clarity about what the command does
  • Updated README.md with more accurate description emphasizing the command validates existing files without building
  • Simplified build-registry.yml workflow by removing the registry.json modification check and replacing with a clarifying comment about path filtering

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
package.json Renames validate-all script to validate-files to better reflect that it validates existing files without building the registry
README.md Updates documentation to clarify that validate-files validates existing files and adds helpful note about building registry first
.github/workflows/build-registry.yml Removes post-merge registry.json modification check and fetch-depth configuration, adds comment explaining path filtering prevents infinite loops

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +10 to +11
# Note: registry.json is in root and doesn't match these patterns,
# so changes to it won't trigger this workflow (preventing infinite loops)
Copy link

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The removed registry.json modification check was the only validation enforcing the documented policy that contributors should NOT commit registry.json in PRs (see CONTRIBUTING.md:165,231). While the build workflow will overwrite any incorrect registry.json after merge, removing this check means policy violations won't be caught or reported.

Consider adding a proper pre-merge check in a PR validation workflow (like validate-manifest.yml) that explicitly fails if registry.json modifications are detected. This would catch violations before merge rather than after, providing better feedback to contributors.

Copilot uses AI. Check for mistakes.
Comment on lines 19 to 20
- name: Checkout repository
uses: actions/checkout@v4
Copy link

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing fetch-depth: 0 changes the checkout behavior from fetching full history to shallow clone (default depth of 1). While this works for the current simplified workflow, it may cause issues if future steps need to access git history for comparisons or validations. Since the workflow no longer needs git history for the removed registry.json check, this change is acceptable but worth noting for future modifications.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants