Skip to content

Update workflow#17

Merged
bthos merged 3 commits intomainfrom
Update-workflow
Feb 13, 2026
Merged

Update workflow#17
bthos merged 3 commits intomainfrom
Update-workflow

Conversation

@bthos
Copy link
Copy Markdown
Collaborator

@bthos bthos commented Feb 13, 2026

Plugin Submission Checklist

  • Plugin ID follows format: author.plugin-name or lowercase-with-hyphens
  • Plugin JSON is valid (CI will validate automatically)
  • SHA256 checksum verified (if distribution with checksums is used)
  • Plugin tested locally
  • README / docs updated if adding new author or changing structure
  • License is valid and specified
  • No malware or suspicious code

Type of Change

  • New plugin
  • Plugin update
  • Metadata fix
  • Documentation
  • Other (describe below)

Plugin Details (if applicable)

Plugin ID:
Version:
License:
Repository / Download URL:

DCO

By submitting this pull request, I certify that my contributions are made under the terms of the Developer Certificate of Origin. All commits are signed off with git commit -s.

Note: DCO requires a valid email address that matches your Git commit author email. See CONTRIBUTING.md for details.

bthos added 2 commits February 13, 2026 22:07
…idate-files` for clarity. Update README.md to reflect the new command and provide additional context on the validation process. Modify GitHub Actions workflow to clarify that changes to `registry.json` won't trigger the build workflow, preventing infinite loops.

Signed-off-by: bthos <el.mogul@outlook.es>
- Introduced `workflow_dispatch` to allow manual triggering of the registry rebuild from the GitHub Actions UI, enhancing flexibility in managing the workflow.

Signed-off-by: bthos <el.mogul@outlook.es>
Copilot AI review requested due to automatic review settings February 13, 2026 21:11
@bthos bthos merged commit c45ef91 into main Feb 13, 2026
1 check passed
@bthos bthos deleted the Update-workflow branch February 13, 2026 21:13
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the validation workflow and CI configuration by renaming the npm script from validate-all to validate-files, removing an ineffective registry.json modification check from the build workflow, and adding manual workflow triggering capability. The changes align the package.json script name with existing usage in the CLI tool and clarify the documentation around validation commands.

Changes:

  • Renamed npm script from validate-all to validate-files in package.json, aligning with existing CLI tool reference
  • Updated README.md documentation to reflect the script rename and clarify its behavior
  • Removed registry.json modification check from build-registry.yml workflow (which ran post-merge, not during PR validation)
  • Added workflow_dispatch trigger to build-registry.yml for manual registry rebuilds
  • Added explanatory comments about infinite loop prevention in the workflow

Reviewed changes

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

File Description
package.json Renames npm script from validate-all to validate-files to match CLI tool usage
README.md Updates documentation to reflect script rename and clarifies validation behavior
.github/workflows/build-registry.yml Removes post-merge registry.json check, adds manual trigger, and improves comments

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 10 to +13
# Note: registry.json is in root and doesn't match these patterns,
# so changes to it won't trigger this workflow (preventing infinite loops)
workflow_dispatch:
# Allows manual triggering of registry rebuild from GitHub Actions UI
Copy link

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The removed registry.json modification check (originally lines 24-42) was the only automated enforcement preventing contributors from committing registry.json in their PRs. While the build-registry workflow will auto-correct any committed registry.json by rebuilding it, this removal means there's no longer enforcement of the documented policy (CONTRIBUTING.md lines 165, 231, 289, 321) that contributors should NOT commit registry.json.

Consider adding a check in validate-registry.yml or validate-manifest.yml that fails if registry.json is detected in the PR's changed files. This would provide earlier feedback to contributors and prevent policy violations from being merged.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants