Pair expected fixtures with canonical sources - #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
*.source.txtfile for each*.expected.jsonfixtureLine NandLines N-Mproposedexamples/README.mdWhy
The existing JSON fixtures were schema-valid and semantically plausible, but they were not paired with canonical source inputs. Anchors such as
ThreadorAlex line 5could pass even when no validator proved that the referenced source existed or supported the record.This change turns the fixtures from output-shape examples into grounded source/output evidence.
Pair contract
Source files contain sequentially numbered lines. Expected records must use
Line NorLines N-M, reference existing lines, and retain substantive overlap with those lines.Validation
All checks passed on the final head: