fix(sessions): refresh model from registry on session restore#502
Merged
fix(sessions): refresh model from registry on session restore#502
Conversation
Persisted sessions store the full model object including contextWindow. After a dependency bump that updates registry metadata (e.g. Opus 4.6 going from 200k to 1M context), restored sessions would still show the old value because setModel() received the stale persisted object. Now re-resolve the model from getModel(provider, id) on restore, picking up the latest contextWindow, pricing, and other metadata. Falls back to the persisted model for custom-gateway models not in the registry.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 620bc4060a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Restored sessions show stale model metadata (e.g. 200k context window for Opus 4.6 instead of 1M) because
setModel()receives the model object as it was persisted — which may predate a dep bump that updated the registry.Root cause
saveSession()serializes the fullagent.stateincluding theModelobject with itscontextWindow, pricing, etc. On restore,loadSession()→setModel(sessionData.model)uses that stale snapshot directly.Fix
refreshModelFromRegistry()re-resolves the persisted model viagetModel(provider, id)from pi-ai's current registry before passing it tosetModel(). If the model isn't in the registry (custom gateways), falls back to the persisted object.This ensures existing sessions automatically pick up:
Testing
npm run build✅npm run test:context✅ (640/640)