Fix battery detection on systems with multiple ACPI batteries by filtering batteries with 0% #120
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
On many laptops with multiple ACPI-reported batteries (e.g.,
Battery 0
andBattery 1
), the current scripts incorrectly read the first battery’s status. Often,Battery 0
is a phantom or inactive battery reporting0%
, causing wrong battery percentage and remaining time displays.Solution:
This patch modifies the battery detection logic in the
tmux-battery
scripts to:Battery 1
) by filtering out phantom batteries reporting0%
.acpi
command usage in all relevant scripts to ignore empty batteries.Impact:
Users with laptops reporting multiple batteries will see accurate battery percentage and remaining time in tmux. This fix improves compatibility and usability significantly.