Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors session lifecycle handling in ai-code-backends-infra.el by extracting repeated logic into focused helper functions, and adds ERT coverage to lock in the refactored behavior. This supports the backend session UX (toggle/reuse/create) while keeping behavior stable and making the core flow easier to reason about.
Changes:
- Extracted session target/context resolution into
ai-code-backends-infra--resolve-session-targetandai-code-backends-infra--resolve-session-context. - Extracted session reuse, successful startup finalization, and startup failure handling into dedicated helpers.
- Added ERT tests covering session reuse behavior, target/context resolution, startup finalization, and startup failure UI messaging.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
ai-code-backends-infra.el |
Refactors session toggle/create flow into smaller helpers for target resolution, reuse, finalize, and failure handling. |
test/test_ai-code-backends-infra.el |
Adds focused ERT tests validating the new helper behaviors and ensuring no regressions in session lifecycle behavior. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using C-c a r to auto suggest the best point to improve, with codex gpt 5.4 x-high model