fix: respect XDG_CONFIG_HOME for collection config path#122
Open
fix: respect XDG_CONFIG_HOME for collection config path#122
Conversation
getConfigDir() was hardcoded to ~/.config/qmd, ignoring XDG_CONFIG_HOME. This made it impossible to run isolated QMD instances with separate collection configs on the same machine (e.g. when embedded by a host application that sets XDG_CACHE_HOME + XDG_CONFIG_HOME). The store already respects XDG_CACHE_HOME for the SQLite database location — this makes config consistent with the XDG Base Directory spec. QMD_CONFIG_DIR still takes precedence when set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
getConfigDir()incollections.tsis hardcoded to~/.config/qmd, ignoring theXDG_CONFIG_HOMEenvironment variable. This makes it impossible to run isolated QMD instances with separate collection configs on the same machine.The store already respects
XDG_CACHE_HOMEfor the SQLite database location, but the collection YAML config doesn't follow the same convention. When a host application (e.g. OpenClaw) sets bothXDG_CACHE_HOMEandXDG_CONFIG_HOMEto isolate its QMD instance, the config still reads/writes from the shared~/.config/qmd/index.yml, causing cross-environment collection pollution.Fix
Check
XDG_CONFIG_HOMEingetConfigDir()before falling back to~/.config/qmd, consistent with the XDG Base Directory Specification.QMD_CONFIG_DIRstill takes precedence when set.Changes
src/collections.ts:getConfigDir()now checksXDG_CONFIG_HOME→$XDG_CONFIG_HOME/qmdPriority:
QMD_CONFIG_DIR>XDG_CONFIG_HOME/qmd>~/.config/qmd