Open
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The qmd wrapper script uses
--import tsxwith a bare specifier, which Node.js resolves relative to the current working directory instead of the package installation directory. This causesERR_MODULE_NOT_FOUNDerrors when tsx is not installed globally.Additionally, tsx is currently listed as a devDependency, but it's required at runtime by the wrapper script.
Solution
This PR implements the fix recommended by analyzing the issue:
find_tsx_loader()function that searches up from the package installation directory to findnode_modules/tsx/dist/loader.mjs, working with both nested and hoisted node_modules layoutsChanges
tsxfromdevDependenciestodependenciesTesting
After these changes,
qmdwill work correctly when installed via:npm install -g @tobilu/qmdbun install -g @tobilu/qmdWithout requiring a separate global tsx installation.
Fixes the ERR_MODULE_NOT_FOUND error reported by users installing qmd.